Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cleanup the thumbnail sidebar when preview errors #976

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

ConradJChan
Copy link
Contributor

If preview fails for a document, make sure to clean up the thumbnails sidebar element as well as the class that was added to the .bp div so that the content is not shifted left as if the sidebar is there

@boxcla
Copy link

boxcla commented Apr 4, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

jstoffan
jstoffan previously approved these changes Apr 4, 2019
jeremypress
jeremypress previously approved these changes Apr 4, 2019
@ConradJChan ConradJChan dismissed stale reviews from jeremypress and jstoffan via 4aa48d4 April 4, 2019 18:03
@ConradJChan ConradJChan force-pushed the thumbs-docviewer-cleanup branch from d260f0d to 4aa48d4 Compare April 4, 2019 18:03
@ConradJChan ConradJChan merged commit 05fa0a2 into box:master Apr 4, 2019
@ConradJChan ConradJChan deleted the thumbs-docviewer-cleanup branch April 4, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants