Update: Open Preview Thumbnails by default #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jeremypress
reviewed
Apr 1, 2019
jstoffan
reviewed
Apr 1, 2019
| this.rootEl.insertBefore(this.thumbnailsSidebarEl, this.containerEl); | ||
|
|
||
| if (this.getCachedThumbnailsToggledState()) { | ||
| this.rootEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAILS_OPEN); |
There was a problem hiding this comment.
Strongly recommend moving this to its own method. The sidebar open class logic is going to be in multiple places and will require a OPEN_ACTIVE class now, as well.
| * localStorage if not cached. Defaults to true if not found. | ||
| * @return {boolean} Whether thumbnails is toggled open or not | ||
| */ | ||
| getCachedThumbnailsToggledState() { |
There was a problem hiding this comment.
Should this live in the Thumbnails Sidebar class?
There was a problem hiding this comment.
I'll do a follow on PR to see how I can clean this up
ConradJChan
force-pushed
the
thumbnails-open
branch
from
ece1f9c to
2986c88
Compare
jstoffan
reviewed
Apr 1, 2019
| const thumbnailsToggledMap = this.cache.get(THUMBNAILS_SIDEBAR_TOGGLED_MAP_KEY) || {}; | ||
| const newThumbnailsToggledMap = { ...thumbnailsToggledMap, [this.options.file.id]: !!isOpen }; | ||
|
|
||
| this.cache.set(THUMBNAILS_SIDEBAR_TOGGLED_MAP_KEY, newThumbnailsToggledMap, true /* useLocalStorage */); |
There was a problem hiding this comment.
Is the /* useLocalStorage */ comment needed? I thought it was a webpack annotation for a second.
There was a problem hiding this comment.
Nah not needed, was a copy pasta
jstoffan
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will open the Preview Thumbnails by default for document viewers. Will also remember on a per file basis (via
localStorage) the toggle state of the thumbnails sidebar.Todo: