Update: Add hover state to thumbnails #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ConradJChan
commented
Mar 26, 2019
ConradJChan
commented
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Mar 26, 2019
src/lib/ThumbnailsSidebar.js
Outdated
| // Appends to the lastChild which should be the thumbnail nav element | ||
| thumbnailEl.lastChild.appendChild(imageEl); | ||
| // Appends to the thumbnail nav element | ||
| thumbnailEl.lastChild.firstChild.appendChild(imageEl); |
There was a problem hiding this comment.
This selection logic is getting pretty hairy. Can we avoid the extra wrapper?
jeremypress
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.