Chore: Add e2e Thumbnail tests for large doc #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
ConradJChan
commented
Mar 13, 2019
jstoffan
previously approved these changes
Mar 13, 2019
|
|
||
| return cy.get('@foundThumbnail'); | ||
| }; | ||
|
|
||
| const showDocumentPreview = ({ enableThumbnailsSidebar } = {}) => { | ||
| cy.showPreview(token, fileId, { enableThumbnailsSidebar }); | ||
| cy.getPreviewPage(1); |
There was a problem hiding this comment.
Is this not already the default behavior of Preview if no page number options are passed in?
| const showDocumentPreview = ({ enableThumbnailsSidebar } = {}) => { | ||
| cy.showPreview(token, fileId, { enableThumbnailsSidebar }); | ||
| cy.getPreviewPage(1); | ||
| cy.contains('The Content Platform for Your Apps'); | ||
| cy.contains('IN THE HOUSE OF REPRESENTATIVES'); |
There was a problem hiding this comment.
Not sure if this needs to be checked each time we load the document. Maybe just in a single test?
jstoffan
reviewed
Mar 14, 2019
jstoffan
previously approved these changes
Mar 14, 2019
jstoffan
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.