Fix: Get response as text from axios #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
approved these changes
Mar 12, 2019
| let transformResponse; | ||
|
|
||
| if (options.responseType === 'text') { | ||
| transformResponse = api.transformTextResponse; |
There was a problem hiding this comment.
Looks like passing undefined also works.
jstoffan
reviewed
Mar 12, 2019
| @@ -60,7 +62,13 @@ const api = { | |||
| * @return {Promise} - XHR promise | |||
| */ | |||
| xhr(url, options = {}) { | |||
| return axios(url, api.filterOptions(options)) | |||
| let transformResponse; | |||
There was a problem hiding this comment.
Does having this undefined affect any other response types?
There was a problem hiding this comment.
should get filtered out on L70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, when specifying
responseType: 'text'axios still returns the response data as parsed json, so adding atransformResponseoption to get the text back for PlainTextViewer content