Chore: Add test for internal presentation links #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
ConradJChan
previously approved these changes
Mar 5, 2019
| cy.contains('LINK TO PAGE 1') | ||
|
|
||
| // Internal links should be rendered with <a> tags by PDF.js | ||
| cy.get('.bp-content a').click(); |
There was a problem hiding this comment.
Would it make sense to do a getByTestId('bp-content').find('a') instead since we have been trying to avoid querying by css classes?
ConradJChan
previously approved these changes
Mar 5, 2019
jstoffan
reviewed
Mar 5, 2019
| cy.showPreview(token, fileWithLinksId); | ||
|
|
||
| // Assert document content is present and clickable | ||
| cy.contains('LINK TO PAGE 1') |
There was a problem hiding this comment.
Is this a link to page 1 or page 3? Also missing a semicolon here.
jstoffan
approved these changes
Mar 5, 2019
| cy.showPreview(token, fileWithLinksId); | ||
|
|
||
| // Assert document content is present and clickable | ||
| cy.contains('LINK TO PAGE 3'); |
There was a problem hiding this comment.
I believe you may be able to do cy.contains('LINK TO PAGE 3').click(); as a single statement.
There was a problem hiding this comment.
For links to work in preview with PPTs, you have to add a shape, so the text isn't actually clickable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.