Update: Animate Thumbnails Sidebar transition #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Mar 4, 2019
jstoffan
reviewed
Mar 4, 2019
jstoffan
previously approved these changes
Mar 4, 2019
jeremypress
reviewed
Mar 5, 2019
ConradJChan
force-pushed
the
animate-sidebar
branch
from
a90c040 to
8a4795b
Compare
jstoffan
previously approved these changes
Mar 12, 2019
JustinHoldstock
previously approved these changes
Mar 12, 2019
pramodsum
previously approved these changes
Mar 12, 2019
added 2 commits
March 12, 2019 14:20
…preview into animate-sidebar
ConradJChan
dismissed stale reviews from pramodsum, JustinHoldstock, and jstoffan
via
377eba6
JustinHoldstock
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the approach of transitioning the
leftproperty of the thumbnails sidebar off to the left of thebp-containerout of sight instead of adjusting the width of the thumbnails sidebar as it is toggled.