Fix: Manually dispatch scroll event #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Feb 25, 2019
| // Some browsers don't fire the scroll event when setting scrollTop | ||
| // (IE11 & Firefox) so we need to manually dispatch the event | ||
| // in order to trigger `onScrollHandler` to render the items | ||
| this.scrollingEl.dispatchEvent(new Event('scroll')); |
There was a problem hiding this comment.
Any issues with the event firing twice on browsers that automatically trigger it?
There was a problem hiding this comment.
I didn't see it firing twice, but I'll double check
There was a problem hiding this comment.
Yeah you're right it fires twice, but the scrollTop is the same so the logic to render items won't get triggered the second invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox and IE11 didn't fire the scroll event when setting
scrollTop, so this fix is to manually dispatch the scroll event inVirtualScrollerso that the items at that scroll point will get rendered