Chore: Replace loading doc loading animation with a GIF #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Feb 12, 2019
src/lib/_loading.scss
Outdated
| .bp .bp-doc.bp-doc-document { | ||
| .pdfViewer .page .loadingIcon { | ||
| background: url('icons/loading.gif') center no-repeat; | ||
| background-size: $spinner-size $spinner-size; |
There was a problem hiding this comment.
This can be folded into background above.
src/lib/_loading.scss
Outdated
| width: 30px; | ||
| .bp-document-preload-wrapper { | ||
| .bp-preload-spinner { | ||
| background: url('icons/loading.gif') center no-repeat; |
There was a problem hiding this comment.
You can use SCSS mixins to avoid repeating styles. Something like:
@mixin spinner() {
background: url('icons/loading.gif') center $spinner-size $spinner-size no-repeat;
}
.bp .bp-doc .pdfViewer .page .loadingIcon {
@include spinner;
}
.bp-preload-spinner {
@include spinner;
// other rules
}
jstoffan
previously approved these changes
Feb 12, 2019
|
Can we remove the styles related to the animation of the div? nvm, was looking at a subset of the changes |
ConradJChan
previously approved these changes
Feb 12, 2019
JustinHoldstock
previously approved these changes
Feb 12, 2019
jeremypress
dismissed stale reviews from JustinHoldstock, ConradJChan, and jstoffan
via
8e4b95d
ConradJChan
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance diff on IE11
Before:
After:
Todo: