Chore(metrics): add new timer for full preview load time tracking #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @JustinHoldstock has signed the CLA. Thanks for the pull request! |
jeremypress
reviewed
Feb 12, 2019
ConradJChan
reviewed
Feb 12, 2019
src/lib/Preview.js
Outdated
| @@ -753,6 +754,10 @@ class Preview extends EventEmitter { | |||
| ); | |||
| } | |||
|
|
|||
| // Start the preview duration timer when the user starts to perceive preview's load | |||
| const tag = Timer.createTag(this.file.id, PREVIEW_LOAD_TIME_TAG); | |||
There was a problem hiding this comment.
Do we care about this metric if reload is called with skipServerUpdate = true? That code path seems to bypass load
There was a problem hiding this comment.
For us, our most important metrics are going to be related to our network response times, and served content times. If it's coming from a "reload" most of the content will already be in the browser cache, which we don't care so much about.
jstoffan
reviewed
Feb 12, 2019
ConradJChan
approved these changes
Feb 12, 2019
pramodsum
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts our apdex and preview load timings at parity with our legacy metrics system.
TODO: