Chore: Add support for integration testing with Cypress #909
Conversation
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
|
@jstoffan Yeah, this was just to get the groundwork in place. Was thinking of creating an on call task to migrate the existing functional tests over to cypress, then we can get rid of the old functional tests. |
| it('Should load a document preview', () => { | ||
| const fileId = Cypress.env('FILE_ID_DOC'); | ||
| cy.showPreview(token, fileId); | ||
| cy.getByTestId('preview-container').contains('The Content Platform for Your Apps', { timeout: 10000 }); |
There was a problem hiding this comment.
Is the timeout needed to account for fetching the file/rep? You should be able to use a combination of cy.route and cy.wait to avoid an arbitrary timeout.
You could also wait for the load event from the Preview object, which would be even better, since it hides the implementation details of file/rep fetching. Props to @jeremypress for that idea.
There was a problem hiding this comment.
I tried the load event approach, but couldn't find a way to have Cypress wait for additional assertions within the 'load' event handler. Instead I wait for the .bp container to have the .bp-loaded class before attempting to assert the content
| let token; | ||
|
|
||
| beforeEach(() => { | ||
| token = Cypress.env('ACCESS_TOKEN'); |
There was a problem hiding this comment.
Seems like this could be made a const and done just inside describe above unless token is modified in tests.
| // Show the preview | ||
| cy.showPreview(token, fileId); | ||
| // Wait for .bp to load viewer | ||
| cy.getByTestId('bp').should('have.class', 'bp-loaded') |
There was a problem hiding this comment.
Should this live in the showPreview helper?
| Cypress.Commands.add('getByTestId', (testId) => cy.get(`[data-testid="${testId}"]`)); | ||
| Cypress.Commands.add('getByTitle', (title) => cy.get(`[title="${title}"]`)); | ||
| Cypress.Commands.add('showPreview', (token, fileId) => { | ||
| cy.get('[data-testid="token"]').type(token); |
There was a problem hiding this comment.
These should be able to use cy.getByTestId since it's declared above.
No description provided.