-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Prevent Annotations errors from triggering a Preview failure #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds ability to emit silent preview errors without triggering the Preview error viewer. This is useful for cases such as annotations, where failures don't necessarily mean that the entire preview experience needs to fail
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
pramodsum
requested review from
JustinHoldstock,
jstoffan,
jeremypress,
ConradJChan and
DanDeMicco
January 25, 2019 23:06
Why not just directly call |
preview.triggerError() generates a more thorough log event which i figured might be useful to also have.
|
This is what we do for silent preview errors in Preview.js
|
jeremypress
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to emit silent preview errors without triggering the Preview error viewer. This is useful for cases such as annotations, where failures don't necessarily mean that the entire preview experience needs to fail
Update tests