Chore: Improve fullscreen logic to use fscreen for compatibility #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Jan 25, 2019
| @@ -84,6 +83,8 @@ class MediaControls extends EventEmitter { | |||
| this.handleAutoplay = this.handleAutoplay.bind(this); | |||
| this.handleSubtitle = this.handleSubtitle.bind(this); | |||
| this.handleAudioTrack = this.handleAudioTrack.bind(this); | |||
| this.handleFullscreenEnter = this.handleFullscreenEnter.bind(this); | |||
There was a problem hiding this comment.
No changes were needed for the regular controls?
There was a problem hiding this comment.
I updated all locations where fullscreen was being used. It looks like the fullscreen button for all other viewers is added via BaseViewer.js.
DanDeMicco
reviewed
Jan 25, 2019
|
Double check ios |
|
@DanDeMicco, thanks for calling it out. I tested iOS yesterday and it seemed to be working correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.