Chore: Upgrade deps and scripts to work with node 10 #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
jstoffan
changed the title
jeremypress
reviewed
Jan 15, 2019
|
Good catch, @jeremypress. I ran the script and didn't see any output. It looks like it's checking the minimum version, which shouldn't conflict with upgrading to node 10. Seems like everything's okay. |
jeremypress
previously approved these changes
Jan 15, 2019
priyajeet
reviewed
Jan 15, 2019
| @@ -0,0 +1 @@ | |||
| registry=https://registry.npmjs.org/ | |||
There was a problem hiding this comment.
weird that this was missing before :O
There was a problem hiding this comment.
in other projects we have both yarnrc and npmrc with this
priyajeet
previously approved these changes
Jan 15, 2019
JustinHoldstock
previously approved these changes
Jan 15, 2019
jstoffan
dismissed stale reviews from JustinHoldstock and priyajeet
via
3de770d
jstoffan
force-pushed
the
node-10
branch
2 times, most recently
from
3de770d to
25e6561
Compare
JustinHoldstock
previously approved these changes
Jan 15, 2019
jeremypress
approved these changes
Jan 15, 2019
priyajeet
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added an
.npmrcfile and package.jsonenginesdeclaration to replace the current version-checking script.