Fix: Focus on correct element when entering fullscreen in Firefox #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
|
Let me know if it's more clear when breaking the cases out like this. If it's too verbose I can move it back to a one liner. |
DanDeMicco
reviewed
Nov 15, 2018
src/lib/Fullscreen.js
Outdated
| // Focus on the fullscreen element so keyboard | ||
| // events are triggered without an extra click | ||
| // If el has target property, then it is an Event | ||
| // otherwise it is a HTMLElement | ||
| const element = el.target || el; | ||
| let element; | ||
| if (elementOrEvent.target) { |
There was a problem hiding this comment.
Could you maybe use getProp here? Something like getProp(elementOrEvent, 'target.activeElement', elementOrEvent)
jstoffan
reviewed
Nov 15, 2018
src/lib/Fullscreen.js
Outdated
| // This is an element | ||
| // On certain browsers (Firefox), the actual target is on the activeElement property of the event target | ||
| element = elementOrEvent.target.activeElement || elementOrEvent.target; | ||
| } else { |
There was a problem hiding this comment.
You could simplify this a bit by avoiding the else clause here.
let element = elementOrEvent;
// Comment explaining why this may sometimes be an event instead of an element
if (element.target) {
element = // etc.
}
element.focus();
jstoffan
approved these changes
Nov 15, 2018
jstoffan
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.