Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Emit pause event with flag if initiated by user #861

Merged

Conversation

JustinHoldstock
Copy link
Contributor

No description provided.

@boxcla
Copy link

boxcla commented Nov 9, 2018

Verified that @JustinHoldstock has signed the CLA. Thanks for the pull request!

@jeremypress
Copy link
Contributor

jeremypress commented Nov 12, 2018

why can't they just get the currentTime of the mediaEl when this event fires? They should already have access to the viewer

@JustinHoldstock JustinHoldstock changed the title Chore: Emit current time of media element on pause Chore: Emit pause event with flag if initiated by user Nov 13, 2018
@JustinHoldstock JustinHoldstock merged commit 8d7091c into box:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants