Fix: Add tabindex to preview container #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
ConradJChan
commented
Nov 5, 2018
src/lib/Fullscreen.js
Outdated
| if (el) { | ||
| // If el has target property, then it is an Event | ||
| // otherwise it is a HTMLElement | ||
| const element = el.target || el; |
There was a problem hiding this comment.
I initially wrote this checking to see if el instanceof Event but couldn't figure out a good way to unit test it so settled on this. Open to suggestions
DanDeMicco
reviewed
Nov 5, 2018
priyajeet
reviewed
Nov 5, 2018
ConradJChan
commented
Nov 6, 2018
DanDeMicco
reviewed
Nov 6, 2018
| * @param {HTMLElement|Event} el - Fullscreen element or event | ||
| * @return {void} | ||
| */ | ||
| focusFullscreenElement = (el) => { |
There was a problem hiding this comment.
This seems like it is pretty generic, maybe add to util.js?
There was a problem hiding this comment.
It is and it isn't, taking either a HTMLElement or Event and extracting out the HTMLElement to focus on seems a bit specific to this logic, maybe if this situation comes up again in another file we can move it then
DanDeMicco
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.