Fix: construct annotator when BoxAnnotations loads #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
pramodsum
reviewed
Sep 13, 2018
JustinHoldstock
approved these changes
Sep 14, 2018
pramodsum
approved these changes
Sep 17, 2018
|
Make sure you test the case where Preview doesn't have to fetch the static assets and an instance of BoxAnnotations is passed as an option to Preview |
JustinHoldstock
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of waiting for the Preview viewer to finish loading before constructing the Annotator (which fetches the annotations for the file) we construct the Annotator as soon as the BoxAnnotations static assets are loaded.
From testing on my computer, saw a slight boost of 200-300ms in loading preview with annotations with caching disabled (or about the time it takes to do a network roundtrip for the annotations call). With caching there wasn't much of a time difference since the BoxAnnotations assets were already fetched.