Chore: Refactor functional tests #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeremypress
commented
Apr 16, 2018
jeremypress
commented
- We only need 1 HTML file now
- Removed use of navigate since that seemed to be flakey
- Switched around how we wait for load to be built in
- Switched to new app where we have upload privileges
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
DanDeMicco
approved these changes
Apr 18, 2018
functional-tests/fileOptions_test.js
Outdated
| } | ||
| ); | ||
|
|
||
| // Sacuelabs ie11 doesn't like audio files | ||
| Scenario('Check preview starts at correct spot for all file types @ci @ie', { retries: 5 }, (I) => { |
There was a problem hiding this comment.
Did you mean to delete this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.