Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unused babel-polyfill #737

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

tonyjin
Copy link
Contributor

@tonyjin tonyjin commented Mar 26, 2018

With Node v8+ we no longer need babel-polyfill for Webpack.

@boxcla
Copy link

boxcla commented Mar 26, 2018

Verified that @tonyjin has signed the CLA. Thanks for the pull request!

@priyajeet
Copy link
Contributor

Probably add these in package.json

"devEngines": {
    "node": ">=8.x",
    "npm": ">=3.x",
    "yarn": ">=1.0.0"
  },

@tonyjin
Copy link
Contributor Author

tonyjin commented Mar 27, 2018

@priyajeet you don't strictly need yarn right? I'll add node & npm. Where's the documentation on this?Couldn't find anything except for github PRs with a quick search of "npm devEngines" or "package.json devEngines"

@tonyjin tonyjin force-pushed the remove-babel-polyfill branch from 8bb7d0c to 1aac889 Compare March 27, 2018 23:03
With Node v8+ we no longer need babel-polyfill for Webpack.
@tonyjin tonyjin force-pushed the remove-babel-polyfill branch from 1aac889 to e565c81 Compare March 28, 2018 00:06
@tonyjin
Copy link
Contributor Author

tonyjin commented Mar 28, 2018

Decided to remove devEngines for now since it doesn't seem to be an official option in npm or yarn, just engines. devEngines seems to be a React-only feature and they have a custom post-install hook that checks this: https://github.com/facebook/fbjs/blob/master/packages/fbjs-scripts/node/check-dev-engines.js#L29-L61

@tonyjin tonyjin merged commit 85f6d7e into box:master Mar 28, 2018
@tonyjin tonyjin deleted the remove-babel-polyfill branch March 28, 2018 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants