Fix: Reduce WebGL checks to reduce instances of Rats! error #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @tonyjin has signed the CLA. Thanks for the pull request! |
jeremypress
reviewed
Mar 20, 2018
| @@ -184,7 +184,7 @@ class Browser { | |||
| if (!gl) { | |||
| const canvas = document.createElement('canvas'); | |||
| // Should stop 'Rats! WebGL hit a snag' error when checking WebGL support | |||
| canvas.addEventListener(EVENT_WEBGL_CONEXT_LOST, (e) => { | |||
| canvas.addEventListener(EVENT_WEBGL_CONTEXT_LOST, (e) => { | |||
There was a problem hiding this comment.
Can we remove the supportsWebGL global variable?
There was a problem hiding this comment.
Will still be useful if someone is viewing a folder that has multiple 3D/360 files since that result will be cached between previews.
We don't use metrics associated with whether the user's browser supports WebGL or 3D rendering, so this removes the WebGL checks from the browser info check for every Preview instance and isolates them to 3D and 360 files, which should reduce instances of the `Rats! WebGL hit a snag.` error.
tonyjin
force-pushed
the
reduce-webgl-checks
branch
from
c99e707 to
e10b9ed
Compare
DanDeMicco
approved these changes
Mar 22, 2018
jeremypress
approved these changes
Mar 22, 2018
pramodsum
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use metrics associated with whether the user's browser supports WebGL or 3D rendering, so this removes the WebGL checks from the browser info check for every Preview instance and isolates them to 3D and 360 files, which should reduce instances of the
Rats! WebGL hit a snag.error.