Fix: Allow annotation text to be selectable #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @tonyjin has signed the CLA. Thanks for the pull request! |
jeremypress
reviewed
Mar 14, 2018
src/lib/viewers/doc/_docBase.scss
Outdated
| @@ -79,6 +79,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| // Allow other text to be selectable | |||
| p, | |||
| span { | |||
There was a problem hiding this comment.
Can you add inputs too? Right now you can't highlight text that you're currently entering.
Old CSS was prevent user selection of anything that wasn't a text layer div to prevent weird selection edge cases. This patch relaxes that to allow selection of <span> and <p> so annotation dialog text can be selected (they use <p>).
tonyjin
force-pushed
the
selectable-annotation-text
branch
from
61d4f3b to
f79dea8
Compare
jeremypress
approved these changes
Mar 15, 2018
pramodsum
approved these changes
Mar 15, 2018
JustinHoldstock
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old CSS was prevent user selection of anything that wasn't a text layer div to prevent weird selection edge cases. This patch relaxes that to allow selection of
<span>,<p>&<input>so annotation dialog text can be selected (they use<p>).