Chore: document controls functional tests + improve reliability #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @DanDeMicco has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Mar 12, 2018
functional-tests/constants.js
Outdated
| @@ -13,3 +13,14 @@ exports.SELECTOR_BOX_PREVIEW_DOC = '.bp-doc'; | |||
| exports.SELECTOR_BOX_PREVIEW_MP3 = '.bp-media-mp3'; | |||
| exports.SELECTOR_BOX_PREVIEW_DASH = '.bp-media-dash'; | |||
| exports.SELECTOR_BOX_PREVIEW_MP4 = '.bp-media-mp4'; | |||
| exports.SELECTOR_BOX_PREVIEW_ZOOM_OUT = '.bp-doc-zoom-out-icon'; | |||
| exports.SELECTOR_BOX_PREVIEW_ZOOM_IN = '.bp-doc-zoom-in-icon'; | |||
There was a problem hiding this comment.
if some of these are buttons could we label them as such? Might make reading the test easier. Also could probably shorten BOX_PREVIEW to bp.
There was a problem hiding this comment.
@jeremypress I will add the button, but perhaps the removal of BOX_PREVIEW should be another PR as it will be quite large
pramodsum
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functional tests for document controls. It also adds some improves and speeds up some flaky tests (Check preview starts at correct spot for all file types)