Fix: Avoid use of Number.isFinite() #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
JustinHoldstock
approved these changes
Mar 8, 2018
DanDeMicco
approved these changes
Mar 8, 2018
priyajeet
reviewed
Mar 8, 2018
| @@ -540,7 +540,8 @@ class MediaBaseViewer extends BaseViewer { | |||
| * @return {boolean} - true if time is valid | |||
| */ | |||
| isValidTime(time) { | |||
| return typeof time === 'number' && Number.isFinite(time) && time >= 0 && time <= this.mediaEl.duration; | |||
| // eslint-disable-next-line | |||
| return typeof time === 'number' && isFinite(time) && time >= 0 && time <= this.mediaEl.duration; | |||
There was a problem hiding this comment.
remove isFinite, since we are doing bounds check
JustinHoldstock
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number.isFinite() is not supported in IE, and all it does is check that the input is a number and call the global isFinite, which is supported everywhere.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite