Chore: Adding download reachability checks to other viewers #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
JustinHoldstock
approved these changes
Mar 7, 2018
DanDeMicco
approved these changes
Mar 8, 2018
src/lib/viewers/media/DashViewer.js
Outdated
| @@ -16,6 +16,9 @@ const MANIFEST = 'manifest.mpd'; | |||
| const DEFAULT_VIDEO_WIDTH_PX = 854; | |||
| const DEFAULT_VIDEO_HEIGHT_PX = 480; | |||
|
|
|||
| const SHAKA_CODE_UNEXPECTED_NETWORK_FAILURE = 1002; | |||
There was a problem hiding this comment.
You can get the error codes from shaka.util.Error.Code. So you should be able to do shaka.util.Error.Code.HTTP_ERROR instead of hard coding the number. Might be more future proof? docs at https://shaka-player-demo.appspot.com/docs/api/lib_util_error.js.html
JustinHoldstock
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on the way, adding checks for media and text viewers.