Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add header for pdf compression #591

Merged

Conversation

JustinHoldstock
Copy link
Contributor

COXP-4418

This PR adds x-box-accept-encoding headers (identity) when range requests are enabled for PDF reps. Once GZip compression is rolled out for PDF representations, this will allow range requests to work.

Do not merge until Box serves PDF representations with GZIP Compression

@boxcla
Copy link

boxcla commented Jan 18, 2018

Verified that @JustinHoldstock has signed the CLA. Thanks for the pull request!

Copy link
Contributor

@jeremypress jeremypress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for when the headers are added.

@tonyjin
Copy link
Contributor

tonyjin commented Mar 15, 2018

When you merge this, please correct the PR title to have the correct Chore: prefix, thanks.

@JustinHoldstock JustinHoldstock changed the title Add header for pdf compression Chore: Add header for pdf compression Mar 21, 2018
@JustinHoldstock JustinHoldstock merged commit ad97a90 into box:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants