Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Media controls and usability fixes for mobile #217

Merged
merged 5 commits into from
Jul 17, 2017
Merged

Fix: Media controls and usability fixes for mobile #217

merged 5 commits into from
Jul 17, 2017

Conversation

jeremypress
Copy link
Contributor

  • Scrubber responds to touch events
  • Controls are toggled on touch
  • Controls are not always force show due to video360 css

JustinHoldstock
JustinHoldstock approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@JustinHoldstock JustinHoldstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jeremypress jeremypress requested review from bhh1988 and pramodsum July 13, 2017 19:35
@jeremypress jeremypress merged commit 38ecce7 into box:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodsum pramodsum pramodsum approved these changes

@JustinHoldstock JustinHoldstock JustinHoldstock approved these changes

@bhh1988 bhh1988 Awaiting requested review from bhh1988

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremypress @JustinHoldstock @pramodsum @tonyjin