New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixes issues with adding annotations on tablets #186

Merged

pramodsum merged 2 commits into box:master from pramodsum:mobile

Jun 27, 2017

Contributor

pramodsum commented Jun 27, 2017

Some listeners were never unbound from the docHighlightDialog which caused issues with the shared mobile dialog
Cleaning up some other small things I noticed relating to highlights

pramodsum added 2 commits

June 26, 2017 22:25


          Fix: Fixes issues with adding annotations on tablets

24b4241


          Chore: Updating unit tests

c4ffc4f

JustinHoldstock approved these changes

View reviewed changes

src/lib/annotations/doc/DocHighlightThread.js

    
                      this.removeAllListeners('annotationcreate');

                      this.removeAllListeners('annotationcancel');

                      this.removeAllListeners('annotationdelete');

                      this.dialog.removeAllListeners('annotationdraw');

Contributor

JustinHoldstock Jun 27, 2017

Good catch!

pramodsum merged commit e6e6c3b into box:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet