Fix: Fix shared links previewed in other subdomains #173
Conversation
| let src = `${appHost}/integrations/officeonline/openExcelOnlinePreviewer`; | ||
| let runmodeSrc = '/integrations/officeonline/openExcelOnlinePreviewer'; | ||
|
|
||
| const domain = document.createElement('a'); |
There was a problem hiding this comment.
Just checking - will this cause issues on IE like that bug you found a few weeks ago?
There was a problem hiding this comment.
good catch. Is there a reason why we created an tag an didn't just use window.location to begin with?
There was a problem hiding this comment.
Creating a tag lets us leverage the browser when parsing out different parts of the domain
| @@ -184,25 +184,28 @@ const MESSAGE_HOST_READY = 'Host_PostmessageReady'; | |||
| */ | |||
| setupRunmodeURL(appHost, fileId, sharedLink) { | |||
| // @TODO(jpress): Combine with setupWopiSrc Logic when removing the platform fork | |||
| let src = `${appHost}/integrations/officeonline/openExcelOnlinePreviewer`; | |||
| let runmodeSrc = '/integrations/officeonline/openExcelOnlinePreviewer'; | |||
There was a problem hiding this comment.
"route" might be a better name for this, just because a runmode isn't actually included in the src URL we build
There was a problem hiding this comment.
Agreed - we also shouldn't have Box-specific language in our code if possible.
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('setupWOPISrc()', () => { | ||
| it('should append the file ID if there is no shared link', () => { | ||
| const src = office.setupWOPISrc(office.options.apiHost, office.options.file.id, office.options.sharedLink); | ||
| expect(src).to.equal('app.box.com/wopi/files/123'); | ||
| expect(src).to.equal('https://app.box.com/wopi/files/123'); | ||
| }); | ||
|
|
||
| it('should append the shared name and file ID if there is a shared link', () => { | ||
| office.options.sharedLink = 'https://app.box.com/s/abcd'; |
There was a problem hiding this comment.
Can you add a few tests for when the appHost name and the shared domain don't match? i.e. appHost = "app" and shared domain = "cloud", appHost = "ibm" and shared domain = "cloud", appHost = "cloud" and shared domain = "app"
No description provided.