Upgrade: Upgrade Shaka-player to fix infinite 401 issue #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjin
approved these changes
Jun 6, 2017
| @@ -129,6 +129,7 @@ const MANIFEST = 'manifest.mpd'; | |||
| this.adapting = true; | |||
| this.player = new shaka.Player(this.mediaEl); | |||
| this.player.addEventListener('adaptation', this.adaptationHandler); | |||
| this.player.addEventListener('error', this.shakaErrorHandler); | |||
There was a problem hiding this comment.
In the future, this.shakaErrorHandler should be self-bound in the constructor. It'll look like this:
class DashViewer extends VideoBaseViewer {
constructor() {
super();
// Bind event handlers
this.shakaErrorHandler = this.shakaErrorHandler.bind(this);
this.adaptationHandler = this.adaptationHandler.bind(this);
}
This way, we can remove autobind. This pattern follows #4 described here: https://medium.freecodecamp.com/react-binding-patterns-5-approaches-for-handling-this-92c651b5af56. We can't use #5 due to issues with arrow class properties and inheritance (React doesn't use inheritance, but composition). #1 isn't relevant. #2 has some performance implications and is also easy to forget to add the .bind. #3 has the same issues as #2 and also can't be unbound.
src/lib/viewers/media/DashViewer.js
Outdated
| `Shaka error. Code = ${shakaError.detail.code}, Category = ${shakaError.detail.category}, Severity = ${shakaError.detail.severity}` | ||
| ); | ||
| error.displayMessage = __('error_refresh'); | ||
| if (shakaError.detail.severity > 1) { |
There was a problem hiding this comment.
Nit: I'd add a line break before this.
This is effectively is an upgrade to 2.1.2 with a fix cherry-picked on top: shaka-project/shaka-player#842. This fixes an issue where 401s would get infinitely retried. In addition, the viewer will bind to error-events thrown from shaka-player and propagate it so that the preview fails faster on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively is an upgrade to 2.1.2 with a fix cherry-picked on
top: shaka-project/shaka-player#842. This fixes an
issue where 401s would get infinitely retried.