fix(docs): Remove gzip encoding query param #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jstoffan
changed the title
jstoffan
previously approved these changes
Oct 18, 2024
| this.encoding = disableRange && disableStream ? ENCODING_TYPES.GZIP : undefined; | ||
|
|
||
| if (this.encoding) { | ||
| queryParams[QUERY_PARAM_ENCODING] = this.encoding; |
There was a problem hiding this comment.
I think we can delete queryParams and remove the appendQueryParams call now, since it's a noop.
minkovich
force-pushed
the
remove_encoding
branch
from
02361da to
9a8b04f
Compare
Box will automatically use accept-encoding header This fixes a bug where gzip encoding wasn't available in accept-encoding list
minkovich
force-pushed
the
remove_encoding
branch
from
9a8b04f to
e952746
Compare
jstoffan
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box will automatically use accept-encoding header
This fixes a bug where gzip encoding wasn't available in accept-encoding list