feat(pdf): Move annotation styling to box-annotations #1497
Conversation
| .ba-Layer--popup, | ||
| .ba-Layer--highlight, | ||
| .ba-Layer--drawing, | ||
| .ba-point-annotation-marker { |
There was a problem hiding this comment.
Is this ba-point-annotation-marker class actually used anywhere? I didn't see this in box-annotations.
There was a problem hiding this comment.
Yeah, I also couldn't find it in annotations, but this needs to move above the text layer to be clickable (it's a fix for expiring embed links - since it's prefixed with ba I figured that annotations would be the best place to put it)
There was a problem hiding this comment.
It's used in a legacy version of box-annotations that's only used by the Expiring Embed flow. So, unless we want to release a patch to v2 of box-annotations, this specific style will need to stay in box-content-preview.
| @@ -9,10 +9,3 @@ | |||
| .bp-AnnotationsControls-exitBtn { | |||
| display: none; | |||
| } | |||
There was a problem hiding this comment.
was ba-point-annotation-marker used anywhere
In v3.6.172 of PDFjs, a z-index styling was explicitly added to pdf_viewer.css: https://cdnjs.cloudflare.com/ajax/libs/pdf.js/3.6.172/pdf_viewer.css. This styling was not present in the previous version of PDFjs that we're using: https://cdnjs.cloudflare.com/ajax/libs/pdf.js/2.14.305/pdf_viewer.css and keeping this new styling causes issues with the other layers in preview (i.e. popup layer, highlighted layer, etc.). Updating styling for our layers resolves the issues that QA has discovered, but moving them to the box-annotations repo is preferable.
Have tested this change in the SDK with the stylings moved to box-annotations/linked with EUA.