fix(a11y): screen reader support for view only file preview #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Aug 1, 2023
arturfrombox
force-pushed
the
fix-a11y-view-only-permissions
branch
from
15bd081 to
b0b2c2d
Compare
jstoffan
previously approved these changes
Aug 2, 2023
src/lib/viewers/doc/_docBase.scss
Outdated
| @@ -304,6 +304,17 @@ $thumbnail-sidebar-width: 191px; // Extra pixel to account for sidebar border | |||
| } | |||
| } | |||
|
|
|||
| .pdfViewer { | |||
| &--viewOnly { | |||
There was a problem hiding this comment.
We typically want to spell out class names so they're easy to search for using our IDEs:
&.pdfViewer--viewOnly
There was a problem hiding this comment.
sure
i just updated the pr
jstoffan
approved these changes
Aug 2, 2023
arturfrombox
force-pushed
the
fix-a11y-view-only-permissions
branch
from
7e2e7e1 to
d5082ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for screen readers and allow to disable copying content for view only PDF documents.
In order to simplify things the "view only" permission was implemented using CSS and JS , which should hopefully suffice.
The advantage of this approach, as opposed to e.g. disabling the textLayer completely, is first of all that it ensures that document is accessible through a screen reader. Secondly this also ensures that searching still works correctly even in copy-protected documents.
This kind of copy-protection is not very strong and is also relatively easy to create some workarounds. Hence a simple solution, targeting "normal"-users rather than "advanced"-users is hopefully deemed acceptable here.
Demo - https://cloud.box.com/s/h9dg4g7bwxorp60qvfvqgu5trjx9v5q6