Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(env): Upgrade node to v14 and yarn to v1.22 #1427

Merged
merged 1 commit into from
Sep 15, 2021
Merged

build(env): Upgrade node to v14 and yarn to v1.22 #1427

merged 1 commit into from
Sep 15, 2021

Conversation

jstoffan
Copy link
Collaborator

No description provided.

@jstoffan jstoffan requested a review from a team as a code owner September 15, 2021 21:20
ConradJChan
ConradJChan approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update package.json?

@jstoffan
Copy link
Collaborator Author

We've run into issues with updating engines in the past, so I figured I'd leave it be. It should still work with Node 10 in theory. Thoughts?

@jstoffan jstoffan merged commit 88c55d8 into box:master Sep 15, 2021
@jstoffan jstoffan deleted the upgrade-node-14 branch September 15, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstoffan @ConradJChan