fix(ThumbnailSidebar): A11Y add descriptive attributes #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tille
changed the title
tille
changed the title
ConradJChan
reviewed
Aug 30, 2021
tille
force-pushed
the
a11y-add-descriptive-attributes-thumbnails-sidebar
branch
from
d57d7f0 to
05a7eb0
Compare
jstoffan
reviewed
Aug 31, 2021
jstoffan
reviewed
Aug 31, 2021
jstoffan
previously approved these changes
Aug 31, 2021
|
@tille, it looks like you may need to squash, rebase, and force push to get past the commit message linter. |
ConradJChan
previously approved these changes
Aug 31, 2021
tille
force-pushed
the
a11y-add-descriptive-attributes-thumbnails-sidebar
branch
from
e9c7c1e to
15e2ae8
Compare
|
@jstoffan squash, done |
jstoffan
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple aria-label attributes for screen-reader users