fix(ThumbnailsSidebar): A11Y - add aria-current to ThumbnailsSidebar #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Aug 5, 2021
| @@ -254,6 +254,7 @@ class ThumbnailsSidebar { | |||
|
|
|||
| if (pageNum === this.currentPage) { | |||
| thumbnailEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAIL_IS_SELECTED); | |||
| thumbnailEl.setAttribute('aria-current', true); | |||
There was a problem hiding this comment.
Does this value get updated as the user changes between pages?
There was a problem hiding this comment.
@jstoffan you are right. I added and removed the aria-current when user changes between pages.
|
@jstoffan I just added an unit test |
jstoffan
reviewed
Aug 6, 2021
|
|
||
| thumbnailsSidebar.applyCurrentPageSelection(); | ||
|
|
||
| expect(stubs.addAriaAttribute).toBeCalledTimes(1); |
There was a problem hiding this comment.
Can we add an assertion for the removeAttribute call, as well, similar to the tests above?
There was a problem hiding this comment.
@jstoffan I just added another unit test case.
jstoffan
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a visual indication of the current thumbnail that also presents the current page You should convey this information to screen reader with aria-current="true". For example: