feat(office): Preview PDF rep if using internet explorer #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
force-pushed
the
ie11-office-deprecation
branch
from
4c5ffbb to
49f9697
Compare
jstoffan
reviewed
Aug 5, 2021
ConradJChan
force-pushed
the
ie11-office-deprecation
branch
from
6b3b6a1 to
48a02ed
Compare
jstoffan
reviewed
Aug 5, 2021
src/lib/viewers/doc/DocBaseViewer.js
Outdated
| @@ -377,6 +379,14 @@ class DocBaseViewer extends BaseViewer { | |||
| this.showPreload(); | |||
|
|
|||
| const template = this.options.representation.content.url_template; | |||
| const { extension } = this.options.file; | |||
There was a problem hiding this comment.
Is this.options.file always defined as an object? Should we move this logic to DocumentViewer?
There was a problem hiding this comment.
Seems like it is always passed into the viewer options:
box-content-preview/src/lib/Preview.js
Line 1211 in 19722e6
ConradJChan
force-pushed
the
ie11-office-deprecation
branch
from
acafa27 to
6b03bec
Compare
jstoffan
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO