fix(controls): color correction on contols #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Jun 23, 2021
| $bp-controls-opacity: .8; | ||
| $bp-controls-outline: inset 0 0 0 1px fade-out($white, .5), 0 1px 2px fade-out($black, .9); | ||
| $bp-controls-opacity: .9; | ||
| $bp-controls-outline: inset 0 0 0 1px fade-out($bdl-gray-20, 0), 0 1px 2px fade-out($black, .9); |
There was a problem hiding this comment.
We should be able to remove the fade-out directive here, since we're passing a zero value to it.
There was a problem hiding this comment.
Thanks Jared. Shouldn't be zero. Updated!
|
@hormaza, can you please include both a "before" and "after" screenshot for all visual changes to preview? Thanks! |
|
Before: The change are minimal. Just a little bit darker and other color to focus indicator. |
ConradJChan
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus indicators have contrast issues:
This commit will increase the background alpha on the toolbar at 90% and increase the brightness of the focus indicators at #D3D3D3 (box-gray-20)