perf(presentation): Improve presentation rendering performance in Safari #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
commented
Jun 15, 2021
| @@ -84,7 +84,6 @@ $thumbnail-sidebar-width: 191px; // Extra pixel to account for sidebar border | |||
| background-color: $d-eight; | |||
| border-radius: $thumbnail-border-radius; | |||
| box-shadow: 0 0 0 1px $off-white, 0 1px 4px 0 rgba(0, 0, 0, .08); | |||
| transition: box-shadow 50ms ease; | |||
There was a problem hiding this comment.
I noticed some jank when mousing quickly over different thumbnails, so I removed this brief transition. It's perf-related, but I can move it to a separate PR if desired.
boxluecke
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Presentation viewer creates all pages of a document as a big stack of elements using absolute positioning. It controls the page elements' visibility via the
visibilitystyle directive. However, unlike other browsers, Safari 14 on MacOS Big Sur seems to frequently layout/paint every page of the document, even if the page hasvisibility: hiddenset. Addingopacity: 0seems to resolve the problem.