Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controls): Add Subtitles menu for Dash #1400

Merged
merged 6 commits into from
Jun 23, 2021

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Jun 8, 2021

TODO:

  • unit tests

Screen Shot 2021-06-08 at 11 02 23 AM

Screen Shot 2021-06-08 at 11 02 28 AM

@ConradJChan ConradJChan requested a review from a team as a code owner June 8, 2021 18:03
src/lib/viewers/controls/media/MediaSettings.tsx Outdated Show resolved Hide resolved
src/lib/viewers/media/DashControls.tsx Outdated Show resolved Hide resolved
src/lib/viewers/controls/media/MediaSettings.tsx Outdated Show resolved Hide resolved
src/lib/viewers/media/DashControls.tsx Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/controls/media/SubtitlesToggle.tsx Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/controls/media/SubtitlesToggle.tsx Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/__tests__/DashControls-test.tsx Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 6d04ebc into box:master Jun 23, 2021
@ConradJChan ConradJChan deleted the dash-controls-cc branch June 23, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants