feat(controls): Audio tracks menu for Dash viewer #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
May 26, 2021
added 2 commits
May 26, 2021 14:44
jstoffan
previously approved these changes
May 26, 2021
jstoffan
approved these changes
May 27, 2021
| onAutoplayChange, | ||
| onRateChange, | ||
| rate, | ||
| }: Props): JSX.Element { | ||
| const autoValue = autoplay ? __('media_autoplay_enabled') : __('media_autoplay_disabled'); | ||
| const rateValue = rate === '1.0' || !rate ? __('media_speed_normal') : rate; | ||
| const labelledAudioTracks = React.useMemo(() => addLabels(audioTracks), [audioTracks]); |
There was a problem hiding this comment.
I feel like this could probably be simplified, but we can go with it for now. We may need to revisit as we add more menus for Dash, since this component will probably get large quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: