fix(controls): Add forwardRef to Dropdown and Checkbox #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
commented
May 14, 2021
| @@ -0,0 +1,7 @@ | |||
| import React from 'react'; | |||
|
|
|||
| declare module 'react' { | |||
There was a problem hiding this comment.
This is needed because React.forwardRef doesn't support Generics typing
ConradJChan
commented
May 14, 2021
| return ( | ||
| <div ref={dropdownElRef} className={classNames('bp-SettingsDropdown', className)}> | ||
| <div className={classNames('bp-SettingsDropdown', className)}> |
There was a problem hiding this comment.
Moved the ref to a separate container on L92 so that clicking on the label is a valid way to close the dropdown
jstoffan
reviewed
May 14, 2021
| @@ -74,52 +71,69 @@ export default function SettingsDropdown<V extends Value = string>({ | |||
|
|
|||
| useClickOutside(dropdownElRef, () => setIsOpen(false)); | |||
|
|
|||
| // Customize the forwarded ref to combine usage with the ref internal to this component | |||
| React.useImperativeHandle( | |||
There was a problem hiding this comment.
It seems unorthodox to expose the button as the component's ref, since it's a compound component. If we want to expose the dropdown itself later, that could get confusing.
added 2 commits
May 14, 2021 14:31
jstoffan
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a console error occurs when opening the
Model3DSettingsmenu becauseSettingsListattempts to set focus to the menu item that correlates to theactiveIndex. SinceSettingsDropdownandSettingsCheckboxItemare functional components, an error is logged.TODO: