feat(controls): Add MP3 settings controls #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
reviewed
Mar 16, 2021
src/lib/viewers/controls/media/MediaSettings/MediaSettingsAutoplay.tsx
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| describe('event handlers', () => { | ||
| test('should surface the selected item on change', () => { |
There was a problem hiding this comment.
Should this test the false option as well?
There was a problem hiding this comment.
I'm not sure it's necessary, since the underlying logic is the same. Thoughts?
There was a problem hiding this comment.
I guess in terms of testing event handlers, that true. Just thought a test to assert the expected options in the menu might be good
ConradJChan
approved these changes
Mar 16, 2021
|
Thanks for the reviews, @ConradJChan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final PR for the changes described in #1340. I'll also open a separate PR to add support global keydown handling for play rate changes.