chore(deps): Upgrade React dependencies to v17 #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
force-pushed
the
upgrade-react
branch
from
52703b2 to
523e1f5
Compare
ConradJChan
reviewed
Feb 26, 2021
|
|
||
| usePreventKey(buttonElRef, ['Enter', 'Space']); | ||
| if (key === 'Enter' || key === 'Space') { | ||
| event.stopPropagation(); |
|
|
||
| // Allow the range input to handle its own left/right keydown events | ||
| if (key === 'ArrowLeft' || key === 'ArrowRight') { | ||
| event.stopPropagation(); // Prevents global key handling |
There was a problem hiding this comment.
Should this comment be applied above to MediaToggle as well?
ConradJChan
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against our React viewers (CSV, ZIP) and the new React controls.