-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawing): show sub-shadow in color picker control button #1318
Merged
ChenCodes
merged 8 commits into
box:master
from
ChenCodes:sub-shadow-not-displayed-in-color-picker
Jan 15, 2021
Merged
fix(drawing): show sub-shadow in color picker control button #1318
ChenCodes
merged 8 commits into
box:master
from
ChenCodes:sub-shadow-not-displayed-in-color-picker
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to rebase |
ChenCodes
force-pushed
the
sub-shadow-not-displayed-in-color-picker
branch
from
January 14, 2021 23:55
699c3ff
to
013c07c
Compare
ConradJChan
reviewed
Jan 15, 2021
ConradJChan
reviewed
Jan 15, 2021
jstoffan
reviewed
Jan 15, 2021
jstoffan
reviewed
Jan 15, 2021
jstoffan
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Demo:
Chrome
Safari
FF
Edge
IE