Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawing): show sub-shadow in color picker control button #1318

Merged

Conversation

ChenCodes
Copy link
Contributor

@ChenCodes ChenCodes commented Jan 14, 2021

Changes in this PR:

  • add sub shadow in color picker control button
  • cross browser testing

Demo:
ezgif com-gif-maker (6)

Chrome
chrome

Safari
safari

FF
firefox

Edge
edge

IE
ie

@ChenCodes ChenCodes requested a review from a team as a code owner January 14, 2021 23:51
@ChenCodes
Copy link
Contributor Author

Need to rebase

@ChenCodes ChenCodes force-pushed the sub-shadow-not-displayed-in-color-picker branch from 699c3ff to 013c07c Compare January 14, 2021 23:55
@ChenCodes ChenCodes requested a review from ConradJChan January 15, 2021 18:14
@ChenCodes ChenCodes merged commit 63f555c into box:master Jan 15, 2021
@ChenCodes ChenCodes deleted the sub-shadow-not-displayed-in-color-picker branch January 15, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants