fix(drawing): emit color event when color picker is opened #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiao6
reviewed
Jan 11, 2021
jstoffan
reviewed
Jan 11, 2021
src/lib/viewers/BaseViewer.js
Outdated
| @@ -1122,6 +1122,11 @@ class BaseViewer extends EventEmitter { | |||
| this.containerEl.classList.add(className); | |||
| } | |||
| } | |||
|
|
|||
| if (mode === AnnotationMode.DRAWING) { | |||
There was a problem hiding this comment.
Is this condition needed or can emit it always? Do we emit this event anywhere else that can be centralized here?
There was a problem hiding this comment.
We can emit it always.
We emit this event in handleAnnotationColorChange in DocBaseViewer and ImageViewer but I think those should be separate from this as handleAnnotationColorChange is tied to the user action of clicking on a color in the ColorPalette. The event that is emitted in BaseViewer is more so tied to the user action of when a user is clicking on the Drawing button to show the Color Picker.
mxiao6
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If the user updates the drawing color in the first browser tab (when there are two tabs open), the cursor color will be stale in the second tab. The proposed fix is to emit the color change event every time the Color Picker is opened - this will ensure that the cursor color matches the color in the Preview Toolbar.
Changes in this PR:
AnnotatonMode.DRAWINGDemo:
