feat(annotations): Emit annotations color #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
jstoffan
reviewed
Dec 15, 2020
mxiao6
changed the title
mxiao6
force-pushed
the
drawing-color
branch
from
f185321 to
b198112
Compare
jstoffan
reviewed
Dec 15, 2020
jstoffan
previously approved these changes
Dec 15, 2020
jstoffan
approved these changes
Dec 15, 2020
| @@ -994,6 +994,7 @@ class BaseViewer extends EventEmitter { | |||
| const annotatorOptions = this.createAnnotatorOptions({ | |||
| annotator: this.annotatorConf, | |||
| features: options && options.features, | |||
| initialColor: this.annotationModule.getColor(), | |||
There was a problem hiding this comment.
In the future, we may want to consider supporting something like an initial object that gets merged into the annotator's initial state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations part: https://github.com/box/box-annotations/pull/653/files