feat(drawing): add color picker component #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Dec 1, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
ChenCodes
commented
Dec 2, 2020
ChenCodes
commented
Dec 2, 2020
ChenCodes
commented
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 3, 2020
jstoffan
reviewed
Dec 3, 2020
src/lib/viewers/controls/color-picker/__tests__/ColorPickerControl-test.tsx
Outdated
Show resolved
Hide resolved
jstoffan
reviewed
Dec 3, 2020
jstoffan
reviewed
Dec 3, 2020
jstoffan
reviewed
Dec 3, 2020
jstoffan
reviewed
Dec 3, 2020
ChenCodes
commented
Dec 3, 2020
jstoffan
reviewed
Dec 3, 2020
jstoffan
approved these changes
Dec 3, 2020
ConradJChan
reviewed
Dec 4, 2020
| export type Props = { | ||
| annotationMode?: AnnotationMode; | ||
| onAnnotationColorClick: (color: string) => void; | ||
| isActive?: boolean; |
| }: Props): JSX.Element | null { | ||
| const [isColorPickerToggled, setIsColorPickerToggled] = useState(false); | ||
|
|
||
| if (annotationMode !== AnnotationMode.DRAWING) { |
There was a problem hiding this comment.
Does this picker need to know about annotations at all? Could the rendering of this ColorPickerControl be controlled by the consuming component?
| })} | ||
| onClick={(): void => setIsColorPickerToggled(!isColorPickerToggled)} | ||
| type="button" | ||
| {...rest} |
There was a problem hiding this comment.
Seems a bit odd to spread the rest props onto a nested elements instead of the root element. Is this needed for something?
| }; | ||
|
|
||
| export default function ColorPickerPalette({ onColorSelect }: Props): JSX.Element { | ||
| const colors = ['#0061d5', '#26c281', '#ed3757', '#f5b31b', '#ffd700', '#4826c2']; |
There was a problem hiding this comment.
Should these colors be moved outside of the function?
| /> | ||
| </div> | ||
| )} | ||
| <button |
There was a problem hiding this comment.
Does this need a resin tag and/or testid attributes? Similarly for the ColorPickerPalette
| onAnnotationModeEscape={onAnnotationModeEscape} | ||
| /> | ||
| </ControlsBar> | ||
| <ControlsBar> |
There was a problem hiding this comment.
Should this be added to the ImageControls as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Demo:
