feat(controls): Create react version of page controls #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Nov 10, 2020
jstoffan
reviewed
Nov 10, 2020
jstoffan
reviewed
Nov 10, 2020
ConradJChan
reviewed
Nov 10, 2020
cweeii
force-pushed
the
create-page-controls-in-react
branch
4 times, most recently
from
3998955 to
d1ad31e
Compare
jstoffan
reviewed
Nov 16, 2020
jstoffan
reviewed
Nov 16, 2020
jstoffan
reviewed
Nov 16, 2020
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
ConradJChan
reviewed
Nov 16, 2020
jstoffan
reviewed
Nov 17, 2020
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/page/__tests__/PageControlsForm-test.tsx
Outdated
Show resolved
Hide resolved
jstoffan
reviewed
Nov 17, 2020
jstoffan
reviewed
Nov 17, 2020
cweeii
commented
Nov 17, 2020
| this.handlePageSubmit = this.handlePageSubmit.bind(this); | ||
| this.handlePageChangeFromScroll = this.handlePageChangeFromScroll.bind(this); | ||
| this.scrollHandler = this.scrollHandler.bind(this); | ||
| this.setPage = this.setPage.bind(this); |
There was a problem hiding this comment.
Just alphabetizing binds!
jstoffan
reviewed
Nov 17, 2020
cweeii
force-pushed
the
create-page-controls-in-react
branch
from
339c465 to
449f1d9
Compare
jstoffan
previously approved these changes
Nov 18, 2020
cweeii
changed the title
jstoffan
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.