feat(controls): Add react version of annotations controls #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
reviewed
Nov 6, 2020
jstoffan
force-pushed
the
react-ui-annotations
branch
from
20c12d3 to
57e22ea
Compare
mxiao6
reviewed
Nov 10, 2020
| this.controls.render( | ||
| <ImageControls | ||
| annotationMode={this.annotationControlsFSM.getMode()} | ||
| hasHighlight={false} |
There was a problem hiding this comment.
Could we remove this property and set false directly on AnnotationsControls inside ImageControls?
There was a problem hiding this comment.
We can, but I figured keeping the two settings together was preferable. The has props default to false, anyway.
mxiao6
previously approved these changes
Nov 10, 2020
mxiao6
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo